Skip to content

h2 tests and deproxy h2 update #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Feb 14, 2023
Merged

h2 tests and deproxy h2 update #387

merged 21 commits into from
Feb 14, 2023

Conversation

RomanBelozerov
Copy link
Contributor

@RomanBelozerov RomanBelozerov commented Jan 24, 2023 •
edited
Loading

Now deproxy h2 client can:

  • send settings frame;
  • update default settings before create connection;
  • accept settings frame with ack flag;
  • wait settings frame with ack flag;
  • saves error codes;
  • send bytes;

handle_read method for deproxy h2 client - now method variable is created when client receives ResponseReceived event. This fixes error of receiving frames other than headers.

Added tests for issue #88:

Verification of correct frames exchange during establishing of h2 connection: get correct SETTINGS frame (with SETTINGS_INITIAL_WINDOW_SIZE parameter), correct WINDOW_UPDATE frame and correct SETTINGS ACK frame.

HPACK entries eviction: we must correctly process the maximum dynamic table and evict old entries - the test must define the table limit and send too many different headers

Use small SETTINGS_MAX_FRAME_SIZE on a client and test that HTTP response headers and body are normally fragmented

Stream IDs: (1) check that even IDs and ID > 0x7fffffff aren't accepted and (2) you cannot reuse old ID (see Victim 1–HTTP/2 Stream Multiplexing (CVE-2016-0150))

For all cases from issue #344

For issue #1394:

Doesn't send more than allowed by per-stream flow control

Added some tests for RFC 7541 and 9113.

@RomanBelozerov
Updated deproxe h2 client.
30e0070 
Now client can:
- send settings frame;
- update default settings before create connection;
- accept settings frame with ack flag;
- wait settings frame with ack flag;

`handle_read` method for deproxy h2 client - now `method` variable is created when client receives `ResponseReceived` event. This fixes error of receiving frames other than headers.
@RomanBelozerov
added exchange test for SETTINGS frames.
849a071
@RomanBelozerov
added test for SETTINGS_INITIAL_WINDOW_SIZE in SETTINGS frame and loc…
a5b44a1 
…al flow control in stream.
@RomanBelozerov
added tests for dynamic table.
27d8273
@RomanBelozerov
added test for SETTINGS_HEADER_TABLE_SIZE in SETTINGS frame
94b739d
@RomanBelozerov
send_settings_frame for deproxy h2 client. Fixed sending all settings.
bad6a1d
@RomanBelozerov
updated test flow control window. Client is closed when FLOW_CONTROL_…
ece8c7c 
…ERROR is received.

Deproxy is updated. Now client saves received error codes in list.
@RomanBelozerov
added test for concurrent streams.
e355614
@RomanBelozerov
update tests_disabled.json
68bc0b3
@RomanBelozerov
updated deproxy h2. Now client can send bytes.
34278b9
@RomanBelozerov
added tests for stream identifier.
639425a
@RomanBelozerov
create base class for h2 tests with deproxy client.
78ca705
@RomanBelozerov
added tests when:
b6350f9 
 - response is larger than SETTINGS_MAX_FRAME_SIZE.
 - request is larger than SETTINGS_MAX_FRAME_SIZE.
@RomanBelozerov
add tests for WindowUpdate and CONTINUATION frames.
f69f164
@RomanBelozerov
added tests for pseudo-headers
6cd771a
@RomanBelozerov
added tests for frame payload length.
7d9a93f
@RomanBelozerov
fixed update_initiate_settings for deproxy h2. Client sent new sett…
153d02f 
…ings but did not change them for itself.
@RomanBelozerov
added tests for connection-specific headers.
455ce8a
@RomanBelozerov
added tests for rewrite dynamic table for response.
68d02ed
@RomanBelozerov
updated tests_disabled.json and added stress test for SETTINGS_HEADER…
0e05a14 
…_TABLE_SIZE
@krizhanovsky krizhanovsky requested a review from const-t February 6, 2023 15:23
const-t
const-t approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@const-t const-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

framework/deproxy_client.py Outdated
@@ -417,6 +427,80 @@ def make_request(self, request: tuple or list or str, end_stream=True, huffman=T
self.stream_id += 2
self.valid_req_num += 1

def update_initiate_settings(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe would be better to use name update_initial_settings instead of update_initiate_settings?

framework/deproxy_client.py Outdated
Comment on lines 396 to 397
if self.selfproxy_present:
self.update_selfproxy()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need it here?

@RomanBelozerov
removed selfproxy for h2, because we does not use it.
6b2ba41 
renamed `update_initiate_settings` method, new name - `update_initial_settings`.
`handle_close` method was removed for case when client receives GOAWAY frame - client must not close connection, Tempesta does it
@RomanBelozerov RomanBelozerov merged commit 1c37a4f into master Feb 14, 2023
@RomanBelozerov RomanBelozerov deleted the rb-88-settings-frame branch February 14, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@const-t const-t const-t approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RomanBelozerov @const-t